Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio in video check crashing on unexpected failures #27600

Merged
merged 1 commit into from Mar 14, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Mar 13, 2024

Fixes the last case from #27588

The failure there is

2024-03-13 12:54:07 [verbose]: Failed when running CheckAudioInVideo: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'length')
2024-03-13 12:54:07 [verbose]: at TagLib.ByteVector.Mid(Int32 startIndex, Int32 length)
2024-03-13 12:54:07 [verbose]: at TagLib.Riff.List.Parse(ByteVector data)
2024-03-13 12:54:07 [verbose]: at TagLib.Riff.List..ctor(File file, Int64 position, Int32 length)
2024-03-13 12:54:07 [verbose]: at TagLib.Riff.AviHeaderList..ctor(File file, Int64 position, Int32 length)
2024-03-13 12:54:07 [verbose]: at TagLib.Riff.File.Read(Boolean read_tags, ReadStyle style, UInt32& riff_size, Int64& tag_start, Int64& tag_end)
2024-03-13 12:54:07 [verbose]: at TagLib.Riff.File..ctor(IFileAbstraction abstraction, ReadStyle propertiesStyle)
2024-03-13 12:54:07 [verbose]: at InvokeStub_File..ctor(Object, Span`1)
2024-03-13 12:54:07 [verbose]: at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)   at TagLib.File.Create(IFileAbstraction abstraction, String mimetype, ReadStyle propertiesStyle)
2024-03-13 12:54:07 [verbose]: at TagLib.File.Create(IFileAbstraction abstraction)
2024-03-13 12:54:07 [verbose]: at osu.Game.Rulesets.Edit.Checks.CheckAudioInVideo.Run(BeatmapVerifierContext context)+MoveNext() in /home/dachb/Documents/opensource/osu/osu.Game/Rulesets/Edit/Checks/CheckAudioInVideo.cs:line 64

Possibly something to report upstream, but definitely should not be resulting in crashes.

@peppy peppy merged commit a47ccb8 into ppy:master Mar 14, 2024
15 of 17 checks passed
@bdach bdach deleted the dont-die-on-audio-in-video-check branch March 14, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants