Add ability to schedule and rotate main menu content #27722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsunyoku this should be good to make a start on for stable implementation. i'd copy the structure and algorithm as much as possible if you can. you're also welcome to wait for review if you want to potentially reduce overheads of applying further changes. |
bdach
reviewed
Mar 26, 2024
I'm not sure why it's failing headless and I'm not particularly interested in finding that out right now.
|
Made one more change (dee8857), seems fine otherwise. |
bdach
previously approved these changes
Mar 26, 2024
bdach
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27680.
This will cone with ASS commands to manage the currently live content, and a stable patch to share the json data source.
I've tried to keep this as simple as possible.