Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Discord URI registration on macOS for now #27789

Merged
merged 1 commit into from Apr 4, 2024

Conversation

smoogipoo
Copy link
Contributor

2024-04-04 00:29:57 [error]: An unhandled error has occurred.
2024-04-04 00:29:57 [error]: System.IO.IOException: Read-only file system : '/~'
2024-04-04 00:29:57 [error]: at System.IO.FileSystem.CreateParentsAndDirectory(String fullPath, UnixFileMode unixCreateMode)
2024-04-04 00:29:57 [error]: at System.IO.FileSystem.CreateDirectory(String fullPath, UnixFileMode unixCreateMode)
2024-04-04 00:29:57 [error]: at System.IO.Directory.CreateDirectory(String path)
2024-04-04 00:29:57 [error]: at DiscordRPC.Registry.MacUriSchemeCreator.RegisterUriScheme(UriSchemeRegister register)
2024-04-04 00:29:57 [error]: at DiscordRPC.Registry.UriSchemeRegister.RegisterUriScheme()
2024-04-04 00:29:57 [error]: at DiscordRPC.DiscordRpcClient.RegisterUriScheme(String steamAppID, String executable)
2024-04-04 00:29:57 [error]: at osu.Desktop.DiscordRichPresence.load(OsuConfigManager config) in /Users/smgi/Repos/osu/osu.Desktop/DiscordRichPresence.cs:line 81

It's trying to create the directory ~/Library/Application Support/discord/games, but since .app bundles are run in Apple's sandbox, they can't just randomly touch the user's home directory. Disabling this for now - issue appears to be known? in the library but has been untouched for the good part of 2+ years.

@peppy
Copy link
Sponsor Member

peppy commented Apr 4, 2024

Glad you caught this before a release...

@peppy peppy merged commit 673882f into ppy:master Apr 4, 2024
10 of 11 checks passed
@smoogipoo
Copy link
Contributor Author

I noticed it during the osu-deploy testing earlier today. It's not fatal - just causes a notification every startup, hence why I forgot about it >_>

@peppy
Copy link
Sponsor Member

peppy commented Apr 4, 2024

It would have broken random shit – the bindable code following it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants