Add verify checks for incorrect audio formats #27895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the corrupt file check from CheckTooShortAudioFiles and makes the audio formats checks deal with it instead to avoid redundant messages.
peppy
reviewed
Apr 17, 2024
bdach
requested changes
Apr 19, 2024
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
|
I've applied further followups. @64ArthurAraujo please check when able for future reference. |
bdach
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 2 checks listed at #12091, based on here. This PR also removes the corrupt check in
CheckTooShortAudioFilesand deals with that situation in the new checks, this is done to avoid 2 messages essentially reporting the same problem at the same time.