Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sound feedback to all tab controls with keyboard interaction #27909

Merged
merged 7 commits into from
Apr 19, 2024

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Apr 17, 2024

See #27657 (comment).

Moving forward, all TabItem implementations must use HoverSounds, and manually load the select sample and play it on OnActivatedByUser. This extends support of sound feedback to trigger via Ctrl-Tab or by calling SelectTab (usually by handling key bindings).

The only behavioural changes by this PR are the following:

  1. Clicking on tabs while they are selected no longer plays a sound as concluded in Add sound feedback to most tab control implementations from keyboard interactions #27657 (comment)
  2. Ctrl-tab now plays sound when there is another tab to switch to, can be noticed in song select's beatmap details/leaderboard tabs on the left side.
  3. F2/F3/F4/F5/Ctrl-Shift-A to switch screens on editor now plays sound.

Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably ok at least it's explicit in behaviour.

@peppy peppy merged commit 78fbc28 into ppy:master Apr 19, 2024
8 of 11 checks passed
@frenzibyte frenzibyte deleted the add-sound-to-tab-selection-change-2 branch April 19, 2024 05:34
peppy added a commit that referenced this pull request May 21, 2024
…lection-change-2"

This reverts commit 78fbc28, reversing
changes made to 863da8b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants