Apply generic math-related changes

[bdach]

To make game compile after ppy/osu-framework#6248.

• Depends on framework package w/ the above

[bdach]

Well that's very red... I'll have to look into what's happened here.

[bdach]

I think I've fixed the issues. They both stem from more stringent checking on the framework side.

cbbf2dd should be self-explanatory, mostly: the initial value DifficultyBindable.maxValue did not match the initial value of DifficultyBindable.CurrentNumber.MaxValue, and the method that updates the bounds of that thing updates them both at once, so when taiko sets MinValue = 0.25, it would attempt to also set MaxValue, to the desynced maxValue which should be 10 but was really 0 - and this would therefore explode due to attempting to set incorrect bounds of [0.25, 0].

787e60f is more complicated. In a few mania health processor tests the draining health processor would actually diverge to the point where drop would be basically double.Epsilon and HpMultiplierNormal would become infinite. This would backfire here:

osu/osu.Game.Rulesets.Mania/Scoring/ManiaHealthProcessor.cs

Line 67 in a35bf77

return HpMultiplierNormal * increase;

If increase is 0, for e.g. mania hold note body, then the above expression becomes 0 * Infinity which is NaN. The previous implementation of clamping was a little dodgy in that it did a max(min(...)), which is fine for normal numbers, but will start doing random things with NaNs because they compare false to everything. The new generic math method refuses to play these games and instead returns NaN, which would then cause the health processor to also receive a NaN because NaNs are also viruses and infect everything, and thus everything catches on fire.

This is fixed by adding an escape hatch when a diverge is detected that just turns off hp drain and resets the multiplier to a neutral 1.

I think these are pretty okay but I am curious of your conclusions.

[smoogipoo]

Makes sense to me