Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply NRT to results-related components #28172

Merged
merged 11 commits into from
May 14, 2024
Merged

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented May 14, 2024

Some more NRT stuff in preparation for attempting to get the whole ScoreInfo mess in results screen under control. End goal is fixing #16480.

I'm not gonna claim I have this figured out start to end, this will be a severe mess to untangle over multiple changes probably, there are several areas of badness in the results screens. So I'm going to do this piece by piece whenever I have the energy to try and continue this.

@peppy peppy self-requested a review May 14, 2024 14:40
@peppy peppy merged commit d74be8b into ppy:master May 14, 2024
11 of 17 checks passed
@bdach bdach deleted the nrt-results-classes branch May 14, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants