Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all difficulty calculators use GetMaxCombo function #29962

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Make all difficulty calculators use GetMaxCombo function #29962

merged 2 commits into from
Sep 25, 2024

Conversation

Givikap120
Copy link
Contributor

Mania requires additional consideration, because GetMaxCombo function is correct for lazer scores but not for stable scores

@bdach
Copy link
Collaborator

bdach commented Sep 24, 2024

!diffcalc

@bdach
Copy link
Collaborator

bdach commented Sep 24, 2024

!diffcalc
RULESET=taiko

@bdach
Copy link
Collaborator

bdach commented Sep 24, 2024

!diffcalc
RULESET=catch

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Target: #29962
Spreadsheet: https://docs.google.com/spreadsheets/d/1wusxD3ZpghSaFXVmWfHWV6x--LZ9-wZsFHXLuF88TRc/edit

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Target: #29962
Spreadsheet:

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Target: #29962
Spreadsheet: https://docs.google.com/spreadsheets/d/1Zxny_ncTK5sqTa8DTUxlELdYXohg0R1mV-zirJ8EmjY/edit

@Givikap120
Copy link
Contributor Author

Target: #29962 Spreadsheet:

?

@bdach
Copy link
Collaborator

bdach commented Sep 25, 2024 

2024-09-24T17:23:42.8688709Z execution-11013205893-11960-1-generator-1  | Adding sheet 'PP Losses (All)'...
2024-09-24T17:23:43.3752062Z execution-11013205893-11960-1-generator-1  | Unhandled exception. 
2024-09-24T17:23:43.3865439Z execution-11013205893-11960-1-generator-1  | The service sheets has thrown an exception.
2024-09-24T17:23:43.3866310Z execution-11013205893-11960-1-generator-1  | HttpStatusCode is BadGateway.
2024-09-24T17:23:43.3867124Z execution-11013205893-11960-1-generator-1  | No JSON error details were specified.
2024-09-24T17:23:43.3867957Z execution-11013205893-11960-1-generator-1  | Raw error details are: <!DOCTYPE html>
2024-09-24T17:23:43.3868669Z execution-11013205893-11960-1-generator-1  | <html lang=en>
2024-09-24T17:23:43.3869558Z execution-11013205893-11960-1-generator-1  |   <meta charset=utf-8>
2024-09-24T17:23:43.3870592Z execution-11013205893-11960-1-generator-1  |   <meta name=viewport content="initial-scale=1, minimum-scale=1, width=device-width">
2024-09-24T17:23:43.3871654Z execution-11013205893-11960-1-generator-1  |   <title>Error 502 (Server Error)!!1</title>
2024-09-24T17:23:43.3872404Z execution-11013205893-11960-1-generator-1  |   <style>
2024-09-24T17:23:43.3977642Z execution-11013205893-11960-1-generator-1  |     *{margin:0;padding:0}html,code{font:15px/22px arial,sans-serif}html{background:#fff;color:#222;padding:15px}body{margin:7% auto 0;max-width:390px;min-height:180px;padding:30px 0 15px}* > body{background:url(//www.google.com/images/errors/robot.png) 100% 5px no-repeat;padding-right:205px}p{margin:11px 0 22px;overflow:hidden}ins{color:#777;text-decoration:none}a img{border:0}@media screen and (max-width:772px){body{background:none;margin-top:0;max-width:none;padding-right:0}}#logo{background:url(//www.google.com/images/branding/googlelogo/1x/googlelogo_color_150x54dp.png) no-repeat;margin-left:-5px}@media only screen and (min-resolution:192dpi){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat 0% 0%/100% 100%;-moz-border-image:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) 0}}@media only screen and (-webkit-min-device-pixel-ratio:2){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat;-webkit-background-size:100% 100%}}#logo{display:inline-block;height:54px;width:150px}
2024-09-24T17:23:43.4009112Z execution-11013205893-11960-1-generator-1  |   </style>
2024-09-24T17:23:43.4010003Z execution-11013205893-11960-1-generator-1  |   <a href=//www.google.com/><span id=logo aria-label=Google></span></a>
2024-09-24T17:23:43.4204185Z execution-11013205893-11960-1-generator-1  |   <p><b>502.</b> <ins>That’s an error.</ins>
2024-09-24T17:23:43.4219178Z execution-11013205893-11960-1-generator-1  |   <p>The server encountered a temporary error and could not complete your request.<p>Please try again in 30 seconds.  <ins>That’s all we know.</ins>
2024-09-24T17:23:43.4220649Z execution-11013205893-11960-1-generator-1  | 
2024-09-24T17:23:43.4221795Z execution-11013205893-11960-1-generator-1  | Google.GoogleApiException: The service sheets has thrown an exception. HttpStatusCode is BadGateway. No error message was specified.
2024-09-24T17:23:43.4223876Z execution-11013205893-11960-1-generator-1  |  ---> Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.
2024-09-24T17:23:43.4225115Z execution-11013205893-11960-1-generator-1  |    at Newtonsoft.Json.JsonTextReader.ParseValue()
2024-09-24T17:23:43.4226236Z execution-11013205893-11960-1-generator-1  |    at Newtonsoft.Json.JsonReader.ReadForType(JsonContract contract, Boolean hasConverter)
2024-09-24T17:23:43.4228006Z execution-11013205893-11960-1-generator-1  |    at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
2024-09-24T17:23:43.4229812Z execution-11013205893-11960-1-generator-1  |    at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
2024-09-24T17:23:43.4231316Z execution-11013205893-11960-1-generator-1  |    at Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader reader, Type objectType)
2024-09-24T17:23:43.4232760Z execution-11013205893-11960-1-generator-1  |    at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
2024-09-24T17:23:43.4234260Z execution-11013205893-11960-1-generator-1  |    at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings)
2024-09-24T17:23:43.4235648Z execution-11013205893-11960-1-generator-1  |    at Google.Apis.Json.NewtonsoftJsonSerializer.Deserialize[T](String input)
2024-09-24T17:23:43.4237362Z execution-11013205893-11960-1-generator-1  |    at Google.Apis.Responses.HttpResponseMessageExtensions.DeserializeErrorAsync(HttpResponseMessage response, String name, ISerializer serializer)
2024-09-24T17:23:43.4238779Z execution-11013205893-11960-1-generator-1  |    --- End of inner exception stack trace ---
2024-09-24T17:23:43.4240275Z execution-11013205893-11960-1-generator-1  |    at Google.Apis.Responses.HttpResponseMessageExtensions.DeserializeErrorAsync(HttpResponseMessage response, String name, ISerializer serializer)
2024-09-24T17:23:43.4241962Z execution-11013205893-11960-1-generator-1  |    at Google.Apis.Requests.ClientServiceRequest`1.ParseResponse(HttpResponseMessage response)
2024-09-24T17:23:43.4243473Z execution-11013205893-11960-1-generator-1  |    at Google.Apis.Requests.ClientServiceRequest`1.ExecuteAsync(CancellationToken cancellationToken)
2024-09-24T17:23:43.4244685Z execution-11013205893-11960-1-generator-1  |    at Google.Apis.Requests.ClientServiceRequest`1.ExecuteAsync()
2024-09-24T17:23:43.4246087Z execution-11013205893-11960-1-generator-1  |    at Generator.Diff.DiffSpreadSheet.AddSheet(IGenerator generator, Object[][] rows) in /workdir/generator/Diff/DiffSpreadSheet.cs:line 34
2024-09-24T17:23:43.4247520Z execution-11013205893-11960-1-generator-1  |    at Program.<Main>$(String[] args) in /workdir/generator/Program.cs:line 71
2024-09-24T17:23:43.4248433Z execution-11013205893-11960-1-generator-1  |    at Program.<Main>(String[] args)
2024-09-24T17:23:43.4249024Z execution-11013205893-11960-1-generator-1  | 
2024-09-24T17:23:43.6066260Z execution-11013205893-11960-1-generator-1  | ./start.sh: line 9:  2384 Aborted                 (core dumped) /out/Generator

I guess let's try that again.

!diffcalc
RULESET=taiko

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Target: #29962
Spreadsheet: https://docs.google.com/spreadsheets/d/1u8q4e72nHMVdUmjdogMQnd8eN5zI5VslVjATiZ58hI8/edit

smoogipoo
smoogipoo approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

@smoogipoo smoogipoo merged commit 5b8ae90 into ppy:master Sep 25, 2024
9 of 13 checks passed
@Givikap120 Givikap120 deleted the use_max_combo branch September 25, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
area:difficulty size/XS type:code-quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Givikap120 @bdach @smoogipoo