Implement Break skipping (Spacebar) #3264
Conversation
| double startTime = -1; | ||
| foreach (var b in breaks) | ||
| { | ||
| if(Time.Current > b.StartTime && Time.Current + skip_required_cutoff + fade_duration < b.EndTime) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Doesn't have to be done in this PR, but at some point there should be a visual element that allows skipping without using a key binding. |
|
I was thinking of reusing the skipoverlay visual elements, I didn't think they would work well with the breakoverlay visual elements, though. But yeah, at some point there should be something. Probably would be best in a different PR. I'll ask about the design it should have if I ever want to implement it, otherwise I'll leave it to you guys. |
|
Out of date, and should also show a skip button. Please re-open with an updated implementation if still interested in giving this a go! My changes in #6901 should be helpful. |
I added the ability to skip breaks by pressing the space bar.