Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better conversion #642

Merged
merged 23 commits into from Apr 18, 2017
Merged

Better conversion #642

merged 23 commits into from Apr 18, 2017

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Apr 18, 2017 •
edited

@smoogipoo smoogipoo requested a review from peppy April 18, 2017 00:45
@peppy peppy mentioned this pull request Apr 18, 2017
Closed
1 task
peppy
peppy reviewed Apr 18, 2017
View reviewed changes
osu.Game.Modes.Osu/Beatmaps/OsuBeatmapConverter.cs Outdated
@@ -33,6 +37,10 @@ private List<OsuHitObject> convertHitObjects(List<HitObject> hitObjects, float s

private OsuHitObject convertHitObject(HitObject original)
{
OsuHitObject originalOsu = original as OsuHitObject;

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@peppy peppy merged commit 0bed537 into ppy:master Apr 18, 2017
@smoogipoo smoogipoo deleted the better-conversion branch February 22, 2018 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smoogipoo @peppy