-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement legacy beatmap encoding for all rulesets #8823
Conversation
I read through this. A few places were a little weird (drumrolls with As to actual correctness of the changes I mostly defer to the tests themselves as I'm not very familiar with the osu! file format but it all looked correct as far as I could tell. History looks bad here too though, same as in the other PR. |
c5a9b3d
to
ba12e23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't see any issues.
Prereqs:
Biggest changes are those to mania since hitobject samples may have changed for converts. It needs to be looked into further anyway, since I'm fairly certain it's not handled correctly anyway:
#8595
#2506