Fix issues with MTL buffer binding optimisation #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
approved these changes
Jan 28, 2024
| @@ -956,29 +956,31 @@ private void BindBuffer(DeviceBufferRange range, uint set, uint slot, ShaderStag | |||
| ? slot + baseBuffer | |||
| : slot + _vertexBufferCount + baseBuffer); | |||
|
|
|||
| if (!_boundVertexBuffers.TryGetValue(index, out var boundBuffer)) | |||
| if (!_boundVertexBuffers.TryGetValue(index, out var boundBuffer) || boundBuffer.Buffer != range.Buffer) | |||
There was a problem hiding this comment.
I mentioned in DM but these dictionary lookups and thrashing are pretty high alloc. For another day but worth mentioning since same line.
There was a problem hiding this comment.
I don't think it's these ones that you mentioned. But yes these ones can likely be removed pretty easily; the MTLCommandBuffer one less so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be pretty obvious.