Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #31 - undefined behaviour in AVX2 version #35

Closed
wants to merge 1 commit into from

Conversation

jansturm92
Copy link

restrict keyword caused undefined compiler output since referenced
objects are overlapping in memory.

e.g, for

polyveck_power2round(&t1, &t0, &t1);

a1 and a in power2round_avx() point to the same object t1.

restrict keyword caused undefined compiler output since referenced
objects are overlapping in memory.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.537% when pulling 826120c on jansturm92:master into 497a98b on pq-crystals:master.

@gregorseiler
Copy link
Member

Thank you for the pull request. These restrict qualifiers are removed in the round 3 code now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants