Explain why a keyboard would be ignored temporarily #3770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamnovak I have also improved the notification window to accommodate longer messages. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #3769 and hopefully reduce the number of lost people chiming in on #1848.
I'm not entirely sure I myself understand the meaning of a "probable stuck key" as detected by https://github.com/pqrs-org/Karabiner-Elements/blob/7b16957729b59587948a640578557696027a6413/src/share/probable_stuck_events_manager.hpp
I think it might mean "this key will probably get stuck if we grab the keyboard", and maybe not "this key is probably stuck on the device and the user should mash it until it seems to work properly". So I've worded the messages kind of vaguely.