-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IJCK reviewer 1 comments #2
Comments
Yeah, not gonna do this. Reviewer 2 wants more detail in many places, and a thorough explanation of all this and examples are important. |
Yeah, but not openly—I just tried to view it, and only people with an account can see it... so it's effectively a private repo. |
Same comments as for #3 ; yes, technically XML is readable because it is written in text, but it is much less understandable. This is widely agreed upon in the tech community... I wonder if there are any citations we can use here. We can mention the new location of PrIMe, but the new features are not documented or explained anywhere. And we certainly can't discuss any plans Frenklach may or may not have in our paper... |
Oh this is new—you can see some information publicly now. I don't think we should adopt this text verbatim, but we can update this slightly. |
Sure, we can add some of this, since ReSpecTh does go beyond just autoignition. |
To some extent, yes, but the format plays a big role in getting people to use and work with the format. Other than saying that, I'm not sure how to support that statement, though. |
Really? We already say you have to register. And there's nothing stopping them from changing this in the future; openness isn't baked in. |
Have you seen anything like this? I'm not entirely sure what this is referring to. |
We'll have to look at v2.0 of their format and update. However, a quick look shows that their |
Reviewer 1 all done! |
I think that the paper contains too much information science details. Still, as the authors note, the description is not comprehensive and they refer to the user manual. I suggest the creation of a significantly abridged version that contains the basic information technology points only and does not discuss the details. For example, Chapter 4 could be deleted and Chapters 2 and 3 may also be shortened.
p. 1 "Competing standards such as the Cantera [2] CTI format or FlameMaster [3] lag behind considerably, although use of the former continually grows due to Cantera’s open availability."
Note that FlameMaster is also freely available from the GitLab repository of the developers.
p. 2 "Second, the XML format is intended to be a machine-readable markup language rather than a data format, and its lack of human readibility presents a barrier to creating and working with database files."
Missing data in the references: Year is missing is refs. [5], [6], [9], [10], [11], [12], [21],[25],[27]
[3] Please add reference: https://www.itv.rwth-aachen.de/index.php?id=13 Also, the latest version is from 2017.
[7] Further info: Paper P1-04, ISBN 978-963-12-1257-0
[8] Please refer to ReSpecTh Kinetics Data Format Specification 2.0 instead.
The text was updated successfully, but these errors were encountered: