Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bundler version from the project to run bundle install #1

Merged
merged 3 commits into from
Feb 8, 2017

Conversation

h13ronim
Copy link
Contributor

@h13ronim h13ronim commented Feb 8, 2017

No description provided.

Copy link
Owner

@pr0d1r2 pr0d1r2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ we can improve

bi.sh Outdated
@@ -1,9 +1,11 @@
unalias bi
function bi() {
local bi_BUNDLER_VERSION_PARAM=""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this initialized with "", this line seems redundant.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After all if we require local declaration of it we can just do:

local bi_BUNDLER_VERSION_PARAM

@h13ronim
Copy link
Contributor Author

h13ronim commented Feb 8, 2017

@pr0d1r2 check again :)

@h13ronim h13ronim changed the title Use bundler version for the project to run bundle install Use bundler version from the project to run bundle install Feb 8, 2017
@pr0d1r2 pr0d1r2 merged commit e4d435b into pr0d1r2:master Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants