Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing GAZEBO_CXX_FLAGS #120

Merged
merged 1 commit into from
Jun 6, 2016
Merged

Conversation

v4hn
Copy link
Member

@v4hn v4hn commented Mar 29, 2016

This is required to compile the plugins with Gazebo 7.

add_compile_options requires cmake 2.8.12 which is around in ubuntu since
14.04.

This is required to compile the plugins with Gazebo 7.

add_compile_options requires cmake 2.8.12 which is around in ubuntu since 14.04.
@v4hn
Copy link
Member Author

v4hn commented Jun 6, 2016

@TheDash: Not sure if you watch these issues, so ping.

Actually, I just realized this bug already got fixed last year in the hydro-devel branch via 08f92c7 .
I guess it's better to just cherry-pick this commit over to indigo-devel.
However, as @ZdenekM pointed out, there is still a bug in that commit.
He proposes a correct fix in #119 and I'd vote for merging his pull-request into hydro-devel /and/ apply both commits to indigo-devel

@TheDash TheDash merged commit 600684f into PR2:indigo-devel Jun 6, 2016
@TheDash
Copy link
Contributor

TheDash commented Jun 6, 2016

Not too concerned about the hydro-devel builds as they are no longer building on the ROS buildfarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants