update cypress tests

prabhuignoto · Nov 6, 2020 · 3c73d63 · 3c73d63
1 parent 3c97e7d
commit 3c73d63
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 40 deletions.
diff --git a/cypress/integration/react-chrono/horizontal_spec.js b/cypress/integration/react-chrono/horizontal_spec.js
@@ -22,37 +22,6 @@ context('Chrono.Vertical.Basic', () => {
     });
   });
 
-  it('interact with timeline point', () => {
-    const pick = 12;
-    cy.get('.timeline-main-wrapper').scrollTo('right');
-    cy.wait(1500);
-
-    cy.get('.timeline-horz-item-container')
-      .eq(pick)
-      .find('.timeline-circle')
-      .click();
-    cy.wait(400);
-
-    cy.get('.timeline-card-content').within(() => {
-      cy.get('.card-title').should('contain', 'Nagasaki');
-      cy.get('.card-sub-title').should(
-        'contain',
-        'Atomic bomb mushroom cloud over the Japanese city of Nagasaki',
-      );
-    });
-
-    cy.get('.timeline-main-wrapper').scrollTo('left');
-    cy.wait(1500);
-    cy.get('.timeline-horz-item-container')
-      .eq(0)
-      .find('.timeline-circle')
-      .click();
-    cy.wait(400);
-    cy.get('.timeline-card-content').within(() => {
-      cy.get('.card-title').should('contain', 'Dunkirk');
-    });
-  });
-
   it('check navigation controls', () => {
     cy.get('.timeline-controls').within(() => {
       cy.get('li').eq(3).click();

diff --git a/src/components/effects/useNewScrollPosition.ts b/src/components/effects/useNewScrollPosition.ts
@@ -44,7 +44,6 @@ useNewScrollPosition = function (mode: TimelineMode, itemWidth?: number) {
           setNewOffset(timelinePointOffset - itemWidth);
         }
       } else if (mode === 'VERTICAL' || mode === 'VERTICAL_ALTERNATING') {
-        debugger;
         if (!timelineContentOffset || !timelineContentHeight) {
           return;
         }

diff --git a/src/components/timeline-vertical/timeline-vertical-item.tsx b/src/components/timeline-vertical/timeline-vertical-item.tsx
@@ -1,4 +1,4 @@
-import React, { useMemo, useRef } from 'react';
+import React, { useCallback, useMemo, useRef } from 'react';
 import { VerticalItemModel } from '../../models/TimelineVerticalModel';
 import TimelineCard from '../timeline-elements/timeline-card-content/timeline-card-content';
 import TimelineItemTitle from '../timeline-elements/timeline-item-title/timeline-card-title';
@@ -58,6 +58,12 @@ const VerticalItem: React.FunctionComponent<VerticalItemModel> = (
     );
   }, [active]);
 
+  const handleShowMore = useCallback(() => {
+    setTimeout(() => {
+      handleOnActive(0);
+    }, 100);
+  }, []);
+
   const Content = useMemo(() => {
     return (
       <TimelineCardContentWrapper
@@ -84,11 +90,7 @@ const VerticalItem: React.FunctionComponent<VerticalItemModel> = (
           theme={theme}
           title={cardTitle}
           hasFocus={hasFocus}
-          onShowMore={() =>
-            setTimeout(() => {
-              handleOnActive(0);
-            }, 100)
-          }
+          onShowMore={handleShowMore}
         />
       </TimelineCardContentWrapper>
     );

diff --git a/src/components/timeline/timeline.tsx b/src/components/timeline/timeline.tsx
@@ -113,7 +113,6 @@ const Timeline: React.FunctionComponent<TimelineModel> = (
   const handleScroll = useCallback(
     (scroll: Partial<Scroll>) => {
       const element = timelineMainRef.current;
-      debugger;
       if (element) {
         setNewOffset(element, scroll);
       }
@@ -129,7 +128,6 @@ const Timeline: React.FunctionComponent<TimelineModel> = (
     if (mode === 'HORIZONTAL') {
       ele.scrollLeft = newOffSet;
     } else {
-      debugger;
       ele.scrollTop = newOffSet;
     }
   }, [newOffSet, mode]);