Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The property timelineContent isn't working for the HORIZONTAL mode. #322

Closed
miral-zymr opened this issue Feb 2, 2023 · 2 comments · Fixed by #323
Closed

The property timelineContent isn't working for the HORIZONTAL mode. #322

miral-zymr opened this issue Feb 2, 2023 · 2 comments · Fixed by #323
Assignees
Labels
bug Something isn't working

Comments

@miral-zymr
Copy link

Describe the bug
The property timelineContent isn't working for the mode=HORIZONTAL. On inspecting, it's not rendering the content mentioned with this property.

To Reproduce
Steps to reproduce the behavior:

const items = [
  { title: 'Timeline title 1', cardTitle: 'Card Title 1' },
  { title: 'Timeline title 2', cardTitle: 'Card Title 2', timelineContent: <span>Test</span> },
];

<Chrono mode="HORIZONTAL" items={items} />;

Expected behavior
Custom React components should be rendered.

CodeSandbox: https://codesandbox.io/s/infallible-microservice-yzfjvz?file=/src/App.js

@prabhuignoto prabhuignoto self-assigned this Feb 3, 2023
@prabhuignoto prabhuignoto added the bug Something isn't working label Feb 3, 2023
@prabhuignoto prabhuignoto linked a pull request Feb 3, 2023 that will close this issue
8 tasks
@prabhuignoto
Copy link
Owner

@miral-zymr This is now fixed with the latest version. you can check and confirm if everything is alright now

@miral-zymr
Copy link
Author

Thanks, @prabhuignoto! This is a great help. Grateful for such a quick response and fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants