Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow esbuild 0.16 #35

Merged
merged 4 commits into from Dec 12, 2022
Merged

feat: allow esbuild 0.16 #35

merged 4 commits into from Dec 12, 2022

Conversation

webdeveric
Copy link
Contributor

  • Set engines.node to be the same as esbuild.
  • Updated dependencies
    • esbuild 0.16
    • TypeScript 4.9
  • Updated TS config to target Node 12

@oyed
Copy link

oyed commented Dec 12, 2022

Looking forward to this - PNPM is complaining about every package in our monorepos right now 😅

@pradel pradel merged commit 881f75b into pradel:main Dec 12, 2022
@webdeveric webdeveric deleted the chore/deps branch December 12, 2022 17:44
@pradel
Copy link
Owner

pradel commented Dec 12, 2022

Thanks for the pr! Published as v1.6.0!

@mmachatschek
Copy link

@webdeveric esbuild was moved from devDependencies to dependencies therefore the peerDependencies mechanism doesn't work as expected anymore

@webdeveric
Copy link
Contributor Author

@mmachatschek It did not move.

"dependencies": {
"find-up": "^5.0.0",
"tslib": "^2.4.1"
},
"peerDependencies": {
"esbuild": "0.12 - 0.16"
},
"devDependencies": {
"@types/node": "16.11.7",
"esbuild": "^0.16.4",
"rimraf": "^3.0.2",
"typescript": "^4.9.4"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants