Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add process/guide - "How to review a PR" #20

Closed
Pradumnasaraf opened this issue May 16, 2022 · 9 comments · Fixed by #79
Closed

[DOCS] Add process/guide - "How to review a PR" #20

Pradumnasaraf opened this issue May 16, 2022 · 9 comments · Fixed by #79
Assignees
Labels
documentation Improvements or additions to documentation EddieHub:good-first-issue EddieHub issue finder good first issue Good for newcomers how-to

Comments

@Pradumnasaraf
Copy link
Owner

Pradumnasaraf commented May 16, 2022

Description

Hey! Contributor,

We are adding a guide/process for every activity (like Creating a PR or raising an issue) and making learning easy for new contributors.

Changes/Action required


If you have any suggestions feel free to Open an Issue

Screenshots

This addition of the documentation will get added and hyperlinked in How-to/README.md and also get hosted on the website https://Opensource.pradumnasaraf.co

Screenshot from 2022-05-15 14-11-21

@Pradumnasaraf Pradumnasaraf added documentation Improvements or additions to documentation good first issue Good for newcomers EddieHub:good-first-issue EddieHub issue finder how-to labels May 16, 2022
Repository owner deleted a comment from KendallDoesCoding May 18, 2022
@KendallDoesCoding
Copy link
Contributor

Can I be assigned? I would like to work on this @Pradumnasaraf

@Pradumnasaraf
Copy link
Owner Author

Can I be assigned? I would like to work on this @Pradumnasaraf

Hey! Kendal, you are already worked on some issues, we can leave them for the others and people new to the Open Source. Hope thing is understandable 😄

@KendallDoesCoding
Copy link
Contributor

Can I be assigned? I would like to work on this @Pradumnasaraf

Hey! Kendal, you are already worked on some issues, we can leave them for the others and people new to the Open Source. Hope thing is understandable 😄

fair enough, but I want to contribute as well.

@Jai-Solania-29
Copy link
Contributor

Hey @Pradumnasaraf I would love to work on this issue 😃.

@Pradumnasaraf
Copy link
Owner Author

Hey @Pradumnasaraf I would love to work on this issue smiley.

Thank you for your interest, go ahead you can work on it

@Jai-Solania-29
Copy link
Contributor

Ok thank you Pradumna 😃

@Pradumnasaraf
Copy link
Owner Author

Hey waiting for your PR. If you have any doubts feel free to ping me!

@Jai-Solania-29
Copy link
Contributor

Hey @Pradumnasaraf I'll push my changes tonight or may be by tomorrow. Actually I was busy in my exams.

@Jai-Solania-29
Copy link
Contributor

Hey @Pradumnasaraf I have made the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation EddieHub:good-first-issue EddieHub issue finder good first issue Good for newcomers how-to
Projects
No open projects
3 participants