Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: allow all html builds #710

Closed
wants to merge 2 commits into from

Conversation

lblythen
Copy link

Replace "or" with "and", so any HTML build is allowed without raising a config error.

lblythen and others added 2 commits August 22, 2023 16:22
Replace "or" with "and" so no HTML build raises config error.
nijel added a commit to WeblateOrg/weblate that referenced this pull request Aug 24, 2023
The additonal formats increase build times and right now fail with
current furo.

See readthedocs/readthedocs.org#3220
See pradyunsg/furo#710
nijel added a commit to WeblateOrg/weblate that referenced this pull request Aug 25, 2023
The additonal formats increase build times and right now fail with
current furo.

See readthedocs/readthedocs.org#3220
See pradyunsg/furo#710
@tasansal
Copy link

Running into this issue with readthedocs! Thanks for sending a fix. Hopefully will be merged soon.

adamchainz added a commit to adamchainz/django-mysql that referenced this pull request Aug 26, 2023
adamchainz added a commit to adamchainz/django-htmx that referenced this pull request Aug 26, 2023
adamchainz added a commit to evansd/whitenoise that referenced this pull request Aug 26, 2023
jab referenced this pull request in jab/bidict Sep 7, 2023
@pradyunsg
Copy link
Owner

Whoops, I ended up looking at this after #709. I think we both ended up on a similar solution to the mistake made here. Thanks for taking the time to file this PR, and apologies for not looking at it sooner. 🙈

Closing this based on the fact that 5abeb9f is basically the same as this logically.

@pradyunsg pradyunsg closed this Sep 9, 2023
@lblythen lblythen deleted the bug/allow-all-html-builds branch September 10, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants