Create TwilML parser #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
March 19, 2015 14:49
| - "pip install coveralls" | ||
| - "python setup.py install" | ||
| script: | ||
| - "coverage run --source=vumi_twilio_api `which py.test` vumi_twilio_api" |
There was a problem hiding this comment.
Don't know why I can only see Simon dH's comment on the indenting in email and not GitHub.
|
👍 on landing and iterating from here. A few general comments:
|
| from setuptools import setup, find_packages | ||
|
|
||
| setup( | ||
| name="vumi_twilio_api", |
There was a problem hiding this comment.
I'm wondering if vxtwilio might be a better name?
There was a problem hiding this comment.
Also wondering whether using Twilio in the name might cause trademark issues? If so, maybe vxtwinio? :)
added 8 commits
March 20, 2015 09:00
|
@hodgestar I've addressed your comments. Ready for another review |
|
👍 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.