-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support hangup verb #7
Conversation
…-support-hangup-verb Conflicts: vumi_twilio_api/twilio_api.py
Conflicts: vumi_twilio_api/twilio_api.py
Ready for review |
}) | ||
elif verb.name == "Hangup": | ||
yield self.reply_to( | ||
message, '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should set content to None
here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed that one. Thanks
Left one very minor comment. Otherwise looks good. |
Issues addressed. |
👍 |
No description provided.