Support gather verb #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 10, 2015 15:30
…-8-support-gather-verb Conflicts: vumi_twilio_api/tests/test_twilio_api.py vumi_twilio_api/twilio_api.py
| if numDigits < 1: | ||
| raise TwiMLParseError( | ||
| "Invalid value %r for numDigits parameter. Must be >=1" | ||
| % numDigits) |
There was a problem hiding this comment.
Maybe it's worthwhile factoring out a simple integer checking function?
added 3 commits
April 14, 2015 12:37
Conflicts: vumi_twilio_api/tests/test_twilio_api.py vumi_twilio_api/twilio_api.py
|
Ready for review. |
| self.assertEqual(gather.nouns[0].name, 'Play') | ||
|
|
||
| def test_gather_from_xml_invalid_sub_verbs(self): | ||
| """Shoudl raise an exception for invalid sub verbs""" |
|
Left one minor comment. Looks good though. There are a lot of TODOs, but I'd like to start trying things out with Rapid before we worry too much about being feature complete. |
|
The TODOS are mostly things that I don't think are necessary for Rapid, but they're there for if something with Rapid doesn't work, we know where to put the feature that needs to be added. Also to keep a note of what we need to add in future if we want to make it feature complete. |
|
Issues addressed. |
|
👍 as soon as Travis is happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.