Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in submission of helpdesk responses to DHIS2 #191

Conversation

rudigiesler
Copy link
Contributor

This PR addresses two issues that we've been having with this task

  1. It's possible that the type of the message is null, we need to handle that and fallback to manually trying to get the content for the content types that we know about
  2. It's possible that a message has a timestamp of null, in which case we need to fallback to the inserted_at timestamp

Copy link
Contributor

@OMosimege OMosimege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good 🍰

Copy link
Contributor

@OMosimege OMosimege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good 🍰

@rudigiesler rudigiesler merged commit 414eef0 into develop Dec 4, 2018
@rudigiesler rudigiesler deleted the feature/MOMZA-1097-fix-dependancy-on-message-type-helpdesk-dhis2 branch December 4, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants