Avoid trailing slash on void elements. #460
Conversation
Although void elements are allowed to have a trailing slash, the W3C Validator will issue a warning in that case: https://github.com/validator/validator/wiki/Markup-%C2%BB-Void-elements
|
¡Muchìsimas gracias por ese PR! ... Firstlly thanx this surely has great value and will be released soon |
|
Hola @RobertDober, muchísimas gracias a tí :) Thanks for reviewing this, of course, feel free to revert some of the changes if needed. Format changes were not intended, and they were applied automatically by my editor. But as those come from the official Let me know if you want me to change anything but yes, feel free to revert changes or improve the PR. |
|
yes we will keep these of course
--
Sed nostra omnis vis in animo et corpore sita est
C. Sallustii Crispi
…On Tue, Apr 25, 2023 at 1:15 PM Jaime Iniesta ***@***.***> wrote:
Hola @RobertDober <https://github.com/RobertDober>, muchísimas gracias a
tí :)
Thanks for reviewing this, of course, feel free to revert some of the
changes if needed.
Format changes were not intended, and they were applied automatically by
my editor. But as those come from the official mix format I thought it
would be OK to leave them.
Let me know if you want me to change anything but yes, feel free to revert
changes or improve the PR.
—
Reply to this email directly, view it on GitHub
<#460 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAASK57PJEZGVS7J7UCUJHDXC6W6HANCNFSM6AAAAAAXK2JLJM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hola again unfortunately the CI is making problems, so I will just merge and change some things back in the tests, if the tests are ok I will release if I have any problems I'll come back to you. Supongo que los tests funccionen en(?) tu maquina local? |
|
Hey yes, the tests pass in my machine :D |
|
CI is waiting for a runner 🏃♀️ |
|
Excellente I had authorized the runner \o/ what happened aùn gracias y voy sicuramente hacer un release este weekend prolongado(sp?) |
|
Ah finally I understand your changes in the tests too! 👍 Getting old I guess 😢 |
|
Published |
|
Great! Thanks! 🥸 |
Although void elements are allowed to have a trailing slash, the W3C Validator will issue a warning in that case, as it's now recommended to avoid trailing slash on void elements:
More information here:
https://github.com/validator/validator/wiki/Markup-%C2%BB-Void-elements