Perform scm updates only on certain events #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgmdev
force-pushed
the
PR/update-on-events
branch
2 times, most recently
from
2d3d750
to
4688af5
Compare
Updates were previously executed by way of a coroutine every second. Even with a cache system in place this caused a performance degradation since git had to scan whole directories for changes. Now we rely on various events instead by hooking into core functions: * DirWatch:check when returning true * DirWatch:watch * DirWatch:unwatch * core.add_project * core.remove_project * core.set_project * core.open_project Now, only the branch is been updated on a coroutine every 3 seconds, that operation should be fast. Maybe on the future we can instead dirwatch specific scm files/folders like .git or .fslckout.
jgmdev
force-pushed
the
PR/update-on-events
branch
from
4688af5
to
636f574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates were previously executed by way of a coroutine every second. Even with a cache system in place this caused a performance degradation since git had to scan whole directories for changes.
Now we rely on various events instead by hooking into core functions:
Now, only the branch is been updated on a coroutine every 3 seconds, that operation should be fast. Maybe on the future we can instead dirwatch specific scm files/folders like .git or .fslckout.