Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve the environment when running pip or setup.py from within the tests #39

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

hroncok
Copy link

@hroncok hroncok commented Nov 26, 2021

No description provided.

@hroncok hroncok changed the base branch from new-package-guidelines to main November 26, 2021 19:25
@hroncok hroncok changed the base branch from main to new-package-guidelines November 26, 2021 19:30
@hroncok
Copy link
Author

hroncok commented Nov 26, 2021

Whatever I try, the CI won't start for me here.

Nevertheless, a local rawhide and f35 mock builds passed for me. It fails on f34 or lower because --in-tree-build is a new option of pip.

I also heavily suggest running subprocess with check=True, so you get the failure when there is one instead of a failed assertion later.

@praiskup
Copy link
Owner

I suppose I can not trigger the workflow (for the first-time contributor) here, could that be because of the "Draft" config?

@praiskup praiskup marked this pull request as ready for review November 26, 2021 21:04
@praiskup
Copy link
Owner

Ok, you need to switch it against main again, so I can press the button ...

@praiskup
Copy link
Owner

Ah, I see now ... you applied this against the proposal branch intentionaly, sorry I'm a bit shifted to other
stuff already ... :-) thank you for the patch!

@praiskup praiskup merged commit f45bb12 into praiskup:new-package-guidelines Nov 26, 2021
@hroncok hroncok deleted the clone_env branch November 27, 2021 01:48
praiskup pushed a commit that referenced this pull request Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants