Skip to content

Commit

Permalink
-Wno-unused-param for proto generated files
Browse files Browse the repository at this point in the history
We have no control over these files as they are generated by the
system-wide installed proto compiler. Let's silence unused-param
warning/error on these.

The upstream issue is this: protocolbuffers/protobuf#2032

and solved in proto version tagged as 3.5.0.1 which is quite new (even
on fedora 27).
  • Loading branch information
pranavk committed Dec 20, 2017
1 parent 97d750a commit 6739fc6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ peloton_protobuf_generate_cpp_py(${proto_gen_folder} proto_srcs proto_hdrs proto

# include python files either to force generation
add_library(peloton-proto STATIC ${proto_hdrs} ${proto_srcs} ${proto_python})
target_compile_options(peloton-proto PRIVATE "-Wno-unused-parameter")
set(Peloton_LINKER_LIBS peloton-proto ${Peloton_LINKER_LIBS}) # note, crucial to prepend!
peloton_default_properties(peloton-proto)

Expand Down

0 comments on commit 6739fc6

Please sign in to comment.