Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused parameter 'deterministic' #2032

Closed
jlippuner opened this issue Aug 30, 2016 · 1 comment
Closed

Unused parameter 'deterministic' #2032

jlippuner opened this issue Aug 30, 2016 · 1 comment

Comments

@jlippuner
Copy link

Every message generates an unused parameter warning for bool deterministic in ::google::protobuf::uint8* <message>::InternalSerializeWithCachedSizesToArray( bool deterministic, ::google::protobuf::uint8* target) const.

This is on git tag v3.0.0.

@khingblue
Copy link
Contributor

Looks like deterministic was added by commit d64a2d9.

Should we keep this variable and use some trick to remove compiler warning, or just remove this variable?

khingblue added a commit to khingblue/protobuf that referenced this issue Sep 6, 2016
Parameter deterministic is unused in InternalSerializeWithCachedSizesToArray(),
which generates unused parameter warning in every message.
liujisi added a commit that referenced this issue Sep 8, 2016
Fix #2032 unused parameter 'deterministic'
pranavk added a commit to pranavk/peloton that referenced this issue Dec 16, 2017
We have no control over these files as they are generated by the
system-wide installed proto compiler. Let's silence unused-param
warning/error on these.

The upstream issue is this: protocolbuffers/protobuf#2032

and solved in proto version tagged as 3.5.0.1 which is quite new (even
on fedora 27).
pranavk added a commit to pranavk/peloton that referenced this issue Dec 20, 2017
We have no control over these files as they are generated by the
system-wide installed proto compiler. Let's silence unused-param
warning/error on these.

The upstream issue is this: protocolbuffers/protobuf#2032

and solved in proto version tagged as 3.5.0.1 which is quite new (even
on fedora 27).
apavlo pushed a commit to cmu-db/peloton that referenced this issue Dec 22, 2017
We have no control over these files as they are generated by the
system-wide installed proto compiler. Let's silence unused-param
warning/error on these.

The upstream issue is this: protocolbuffers/protobuf#2032

and solved in proto version tagged as 3.5.0.1 which is quite new (even
on fedora 27).
mtunique pushed a commit to mtunique/peloton that referenced this issue Apr 16, 2019
We have no control over these files as they are generated by the
system-wide installed proto compiler. Let's silence unused-param
warning/error on these.

The upstream issue is this: protocolbuffers/protobuf#2032

and solved in proto version tagged as 3.5.0.1 which is quite new (even
on fedora 27).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants