Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some language strings are missing. And other... #192

Closed
EV-soft opened this issue Jul 6, 2019 · 4 comments
Closed

Some language strings are missing. And other... #192

EV-soft opened this issue Jul 6, 2019 · 4 comments

Comments

@EV-soft
Copy link

EV-soft commented Jul 6, 2019

I have made some changes and adjustments that can inspire a future version.
Here is a list of the topics:

Table: Zebra-background on rows
Added Color gold on folder icon
Show Folder size - custom activating in settings {search: $calc_folder}
New translate system: scann for UI-strings with prefix: '@_' 
Added detailed explanation  {search:   INFO }
Danish language  {se Updated translation.json "name": "Dansk / Danish" }
Hide Permissions and Owner cols in file-listing - custom activating in settings  {search: $hide_Cols }
Add custom icon in header  {search: $cust_icon }    
Align right in column 'Size' (alignment!)
Change byte unit 'B' to ' B' (alignment!)
Updated file: translation.json (english: see function createLngTable() )
Extended the translate system: add errormess and other UI-strings that was missing {search: '@_ } (52  strings => 200+ strings)
Custom title-tip: data-title= "TIP"
Changed filesize output, for correct sortion by size
Changed filetime output, for correct sortion by time: $datetime_format = 'Y-m-d H:i';
Unresolved: link to parent should stay on top on sorting
User setting for AdvancedEditor (mode and) theme
Added file-name i bread-crumb, so you can see what you are editing.

Some of them concern issues #184 #185 and #188
See and test files in this zip:
TFM-EV-soft.zip

@prasathmani
Copy link
Owner

Let me check and add your valuable features.

@EV-soft
Copy link
Author

EV-soft commented Jul 9, 2019

Another suggestion for improvement,
so save configuration also works when the file is located in subfolder.

function save()
    {
        //global $root_path;
        //$fm_file = $root_path.$_SERVER["PHP_SELF"];
        //$fm_file = __FILE__;
        $var_name = '$CONFIG';
        $var_value = var_export(json_encode($this->data), true);
        $config_string = "<?php" . chr(13) . chr(10) . "//".trans('@_Default Configuration').chr(13) . chr(10)."$var_name = $var_value;" . chr(13) . chr(10);
        $lines = file(__FILE__);
        if ($fh = @fopen(__FILE__, "w")) {
            @fputs($fh, $config_string, strlen($config_string));
            for ($x = 3; $x < count($lines); $x++) {
                @fputs($fh, $lines[$x], strlen($lines[$x]));
            }
            @fclose($fh);
        }
        else { fm_set_msg('@_Configuration was not saved.', 'error');   fm_show_message(); }
    }
}

@EV-soft
Copy link
Author

EV-soft commented Jul 13, 2019

I have now also added the possibility that the user himself can add missing translations (not yet working). Go to settings.
You can see my demo here:
https://www.sky-box.dk/tinyFM/TFM_EV-soft.php
and get our copy. (search for function LanguageList)

prasathmani pushed a commit that referenced this issue Jul 23, 2019
view file is insecure #187
Get files size (recursive) #186
There is no possibility for translation for some hints (title =) #185
View dirSize instead of word "Folder" #184
Document type detection #183
Stored Cross-site Scripting (XSS) Vulnerability detected in File Names #180
strings in code #177
Remove tracking #164
@prasathmani
Copy link
Owner

Added few feature from your suggestion, thanks for your great inputs. @EV-soft

ner00 pushed a commit to ner00/tinyfilemanager that referenced this issue May 7, 2023
view file is insecure prasathmani#187
Get files size (recursive) prasathmani#186
There is no possibility for translation for some hints (title =) prasathmani#185
View dirSize instead of word "Folder" prasathmani#184
Document type detection prasathmani#183
Stored Cross-site Scripting (XSS) Vulnerability detected in File Names prasathmani#180
strings in code prasathmani#177
Remove tracking prasathmani#164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants