New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark path prop as optional #45

Open

devmattrick wants to merge 1 commit into prateekbh:master from devmattrick:fix/optional-path-prop

devmattrick commented Jul 31, 2021

The path prop on the AsyncRoute component is not required like the TypeScript types currently reflect. This PR simply marks it as optional.

I bumped into this issue when I was trying to use an AsyncRoute as the default route like mentioned in the preact-router docs:

<Router>
  <A path="/" />
  <B path="/b" id="42" />
  <C path="/c/:id" />
  <C path="/d/:optional?/:params?" />
  <D path="/e/:remaining_path*" />
  <E path="/f/:remaining_path+" />
  <F default />   <-- There is no path attribute on this component
</Router>

Thanks!


          Mark path prop as optional

b2dbb04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet