Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6688: LTS - Fix integer overflow in TruncateOperation. #6691

Merged

Conversation

sachin-j-joshi
Copy link
Contributor

Signed-off-by: Sachin Joshi sachin.joshi@emc.com

Change log description
Fix integer overflow in TruncateOperation.

Purpose of the change
Fixes #6688

What the code does
Fix integer overflow in TruncateOperation.

How to verify it
Unit tests should pass.

Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
@sachin-j-joshi
Copy link
Contributor Author

sachin-j-joshi commented Apr 12, 2022

FYI - @AJadhav29 @AndreyKoltsov1997

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #6691 (6cf717b) into master (e05a7fb) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6691      +/-   ##
============================================
- Coverage     86.30%   86.30%   -0.01%     
+ Complexity    15743    15740       -3     
============================================
  Files          1022     1022              
  Lines         58852    58852              
  Branches       5960     5960              
============================================
- Hits          50793    50790       -3     
- Misses         4951     4954       +3     
  Partials       3108     3108              
Impacted Files Coverage Δ
...mentstore/storage/impl/bookkeeper/LogMetadata.java 94.23% <ø> (ø)
...main/java/io/pravega/cli/admin/utils/ZKHelper.java 81.63% <100.00%> (ø)
...entstore/storage/chunklayer/TruncateOperation.java 95.02% <100.00%> (+1.49%) ⬆️
...hared/security/crypto/StrongPasswordProcessor.java 87.50% <0.00%> (-6.25%) ⬇️
...ain/java/io/pravega/client/stream/impl/Pinger.java 94.82% <0.00%> (-3.45%) ⬇️
...a/segmentstore/server/logs/OperationProcessor.java 88.88% <0.00%> (-1.80%) ⬇️
...ga/controller/fault/ControllerClusterListener.java 85.96% <0.00%> (-1.76%) ⬇️
...ntstore/storage/impl/bookkeeper/BookKeeperLog.java 83.54% <0.00%> (-1.55%) ⬇️
...egmentstore/storage/chunklayer/WriteOperation.java 94.19% <0.00%> (-1.34%) ⬇️
...mentstore/server/host/stat/AutoScaleProcessor.java 86.95% <0.00%> (-0.73%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeee945...6cf717b. Read the comment docs.

Copy link
Contributor

@RaulGracia RaulGracia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please create a cherry pick of this for 0.11.

@RaulGracia RaulGracia merged commit db14f5a into pravega:master Apr 13, 2022
sachin-j-joshi added a commit to sachin-j-joshi/pravega that referenced this pull request Apr 13, 2022
…#6691)

Fix integer overflow in TruncateOperation.

Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
RaulGracia pushed a commit that referenced this pull request Apr 13, 2022
Fix integer overflow in TruncateOperation.

Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache exhaust due to inability of StorageWriter to make progress
2 participants