-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 6803: Fix standalone log location prompt #6788
Conversation
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
6a9ef49
to
e5cf244
Compare
Thanks @shoothzj for your contribution. Before going into review process, we have some guidelines in the project to propose PRs: https://github.com/pravega/pravega/wiki/Contributing#issues-and-pull-requests At least, I miss an issue that explains the problem this PR intents to solve. Also, while I understand that the change proposed my be difficult to test (is just the location of the log for standalone), maybe you could fill up the PR with a |
@RaulGracia Thanks, I created #6803 and fill the |
Codecov Report
@@ Coverage Diff @@
## master #6788 +/- ##
=========================================
Coverage 86.42% 86.42%
+ Complexity 15928 15926 -2
=========================================
Files 1026 1026
Lines 59423 59423
Branches 6014 6014
=========================================
+ Hits 51357 51359 +2
Misses 4924 4924
+ Partials 3142 3140 -2
Continue to review full report at Codecov.
|
@RaulGracia PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the contribution @shoothzj! |
Correct the log location prompt in standalone. Signed-off-by: ZhangJian He <shoothzj@gmail.com> Signed-off-by: Bhupender-Y <Bhupender.Y@dell.com>
Change log description
Correct the log location prompt.
Purpose of the change
Fixes #6803.
How to verify it
Launch Pravega in standalone mode, and check the
standalone.log
and the prompt.