Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6803: Fix standalone log location prompt #6788

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

shoothzj
Copy link
Contributor

@shoothzj shoothzj commented Jun 24, 2022

Change log description
Correct the log location prompt.

Purpose of the change
Fixes #6803.

How to verify it
Launch Pravega in standalone mode, and check the standalone.log and the prompt.

Signed-off-by: ZhangJian He <shoothzj@gmail.com>
@RaulGracia
Copy link
Contributor

Thanks @shoothzj for your contribution. Before going into review process, we have some guidelines in the project to propose PRs: https://github.com/pravega/pravega/wiki/Contributing#issues-and-pull-requests

At least, I miss an issue that explains the problem this PR intents to solve. Also, while I understand that the change proposed my be difficult to test (is just the location of the log for standalone), maybe you could fill up the PR with a How to verify section showing the result of the change proposed while running standalone locally, as a way to validate it. Thanks!

@shoothzj shoothzj changed the title Fix standalone log location prompt Issue 6803: Fix standalone log location prompt Jul 11, 2022
@shoothzj
Copy link
Contributor Author

@RaulGracia Thanks, I created #6803 and fill the How to verfiy chapter. :)

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #6788 (c9ed1a8) into master (62d05db) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6788   +/-   ##
=========================================
  Coverage     86.42%   86.42%           
+ Complexity    15928    15926    -2     
=========================================
  Files          1026     1026           
  Lines         59423    59423           
  Branches       6014     6014           
=========================================
+ Hits          51357    51359    +2     
  Misses         4924     4924           
+ Partials       3142     3140    -2     
Impacted Files Coverage Δ
...pravega/segmentstore/storage/noop/NoOpStorage.java 94.73% <0.00%> (-2.64%) ⬇️
...erver/tables/FixedKeyLengthTableSegmentLayout.java 80.00% <0.00%> (-2.33%) ⬇️
...ient/segment/impl/AsyncSegmentInputStreamImpl.java 84.02% <0.00%> (-2.09%) ⬇️
...o/pravega/segmentstore/server/logs/DurableLog.java 92.45% <0.00%> (-1.26%) ⬇️
...server/containers/ContainerEventProcessorImpl.java 87.20% <0.00%> (-1.17%) ⬇️
...tore/server/containers/StreamSegmentContainer.java 89.39% <0.00%> (-0.65%) ⬇️
...gmentstore/storage/metadata/BaseMetadataStore.java 97.43% <0.00%> (-0.29%) ⬇️
...ga/controller/task/Stream/StreamMetadataTasks.java 86.43% <0.00%> (+0.21%) ⬆️
...ver/containers/StreamSegmentContainerMetadata.java 97.45% <0.00%> (+0.63%) ⬆️
...mentstore/server/host/stat/AutoScaleProcessor.java 87.68% <0.00%> (+0.72%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d05db...c9ed1a8. Read the comment docs.

@shoothzj
Copy link
Contributor Author

@RaulGracia PTAL

@RaulGracia RaulGracia self-requested a review July 12, 2022 08:21
Copy link
Contributor

@RaulGracia RaulGracia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RaulGracia RaulGracia merged commit c1832e0 into pravega:master Jul 12, 2022
@RaulGracia
Copy link
Contributor

Thanks for the contribution @shoothzj!

@shoothzj shoothzj deleted the wrong-standalone-prompt branch July 12, 2022 09:08
Bhupender-Y pushed a commit to Bhupender-Y/pravega that referenced this pull request Oct 3, 2022
Correct the log location prompt in standalone.

Signed-off-by: ZhangJian He <shoothzj@gmail.com>
Signed-off-by: Bhupender-Y <Bhupender.Y@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standalone log location prompt is wrong
2 participants