Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6896: LTS - Refactor FlakyChunkStorage by moving it to top level and using wrapper pattern. #6897

Conversation

sachin-j-joshi
Copy link
Contributor

@sachin-j-joshi sachin-j-joshi commented Sep 30, 2022

Signed-off-by: Sachin Joshi sachin.joshi@emc.com

Change log description
Refactor FlakyChunkStorage by moving it to top level and using wrapper pattern.

Purpose of the change
Fix #6896

What the code does
Note that this is a test only change.

  • It pulls out FlakyChunkStorage and other related existing inner classes from SystemJournalOperationsTests to top level classes.
  • Also instead of using inheritance based implementation switch to wrapper based implementation, so that it can wrap and intercept calls to any ChunkStorage implementation.

How to verify it
All tests should pass.

@sachin-j-joshi
Copy link
Contributor Author

@AJadhav29 @Amit-Singh40 Please review.

…nd using wrapper pattern.

Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
@sachin-j-joshi sachin-j-joshi force-pushed the issue-6896-LTS-refactor-flaky-storage branch from ebd1d2d to cd93f55 Compare September 30, 2022 22:15
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 86.33% // Head: 86.31% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (dc792d8) compared to base (d944307).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6897      +/-   ##
============================================
- Coverage     86.33%   86.31%   -0.02%     
+ Complexity    15885    15883       -2     
============================================
  Files          1026     1026              
  Lines         59151    59151              
  Branches       5985     5985              
============================================
- Hits          51068    51059       -9     
- Misses         4958     4964       +6     
- Partials       3125     3128       +3     
Impacted Files Coverage Δ
...mentstore/storage/mocks/InMemoryMetadataStore.java 86.76% <0.00%> (-1.48%) ⬇️
...a/segmentstore/server/logs/OperationProcessor.java 90.35% <0.00%> (-1.43%) ⬇️
...a/io/pravega/segmentstore/server/CacheManager.java 83.25% <0.00%> (-1.40%) ⬇️
...egmentstore/storage/chunklayer/WriteOperation.java 94.19% <0.00%> (-1.34%) ⬇️
...o/pravega/client/stream/impl/ReaderGroupState.java 92.58% <0.00%> (-0.91%) ⬇️
.../segmentstore/server/tables/ContainerKeyIndex.java 93.54% <0.00%> (-0.88%) ⬇️
...ntstore/storage/impl/bookkeeper/BookKeeperLog.java 82.26% <0.00%> (-0.78%) ⬇️
.../server/attributes/SegmentAttributeBTreeIndex.java 89.89% <0.00%> (-0.28%) ⬇️
...ga/controller/task/Stream/StreamMetadataTasks.java 86.43% <0.00%> (+0.32%) ⬆️
...io/pravega/common/concurrent/DelayedProcessor.java 90.24% <0.00%> (+1.21%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RaulGracia RaulGracia merged commit 3550686 into pravega:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LTS - Refactor FlakyChunkStorage by moving to top level and using wrapper pattern.
2 participants