Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 6993: Cherry-pick PR #6974 to master #6994

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Issue 6993: Cherry-pick PR #6974 to master #6994

merged 1 commit into from
Feb 6, 2023

Conversation

ShwethaSNayak
Copy link
Contributor

@ShwethaSNayak ShwethaSNayak commented Feb 6, 2023 •
edited by RaulGracia
Loading

Change log description
see #6974

Purpose of the change
Fixes #6993

What the code does
see #6974

How to verify it
All tests should pass.

@ShwethaSNayak
Issue 2166: Improve logging for outstanding checkpoint (pravega#6974)
104dfbd 
Maximum outstanding checkpoint warning message gives info only about blocked checkpoints not on the readers who are actually blocking it.
In one of use case, we could see that though all readers successfully acknowledge the checkpoints, while triggering new initiate checkpoint call it still complains with checkpoints being blocked but here, we have lack of info on the readers who is actually blocking these checkpoints

Signed-off-by: Shwetha N <shwetha.n1@dell.com>
@RaulGracia
Copy link
Contributor

@ShwethaSNayak next time, please create the original PR in master so we can cherry-pick it to release branches, which is the standard workflow. What is being done here is not standard and should be avoided unless there is no other choice. Also, I suppose that r0.13 is also missing this change, right?

@ShwethaSNayak
Copy link
Contributor Author

@RaulGracia, as I was not aware of it raised PR against 0.12 branch, going forward will follow the standard procedure. Yes, this change is not available in 0.13 branch, once it's been merged to master then will cherry-pick to Pravega 01.3.

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 86.38% // Head: 86.36% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (104dfbd) compared to base (95e8001).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6994      +/-   ##
============================================
- Coverage     86.38%   86.36%   -0.03%     
+ Complexity    15985    15978       -7     
============================================
  Files          1029     1029              
  Lines         59425    59429       +4     
  Branches       6012     6012              
============================================
- Hits          51336    51326      -10     
- Misses         4952     4954       +2     
- Partials       3137     3149      +12
Impacted Files Coverage Δ
...io/pravega/client/stream/impl/CheckpointState.java 89.68% <75.00%> (-0.49%) ⬇️
...vega/client/stream/impl/EventStreamReaderImpl.java 90.78% <100.00%> (ø)
...io/pravega/client/stream/impl/ReaderGroupImpl.java 79.45% <100.00%> (+3.48%) ⬆️
...hared/security/crypto/StrongPasswordProcessor.java 87.50% <0.00%> (-6.25%) ⬇️
...egmentstore/server/containers/MetadataCleaner.java 87.32% <0.00%> (-2.82%) ⬇️
...erver/tables/FixedKeyLengthTableSegmentLayout.java 80.00% <0.00%> (-2.33%) ⬇️
...io/pravega/common/concurrent/OrderedProcessor.java 85.71% <0.00%> (-1.79%) ⬇️
...a/segmentstore/server/logs/OperationProcessor.java 90.52% <0.00%> (-1.41%) ⬇️
...ga/client/connection/impl/TcpClientConnection.java 87.75% <0.00%> (-1.37%) ⬇️
...o/pravega/client/stream/impl/ReaderGroupState.java 93.12% <0.00%> (-1.27%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RaulGracia RaulGracia changed the title Issue 6993 : Cherry-pick PR #6974 to master Issue 6993: Cherry-pick PR #6974 to master Feb 6, 2023
@tkaitchuck tkaitchuck merged commit 37b3257 into pravega:master Feb 6, 2023
@ShwethaSNayak ShwethaSNayak mentioned this pull request Feb 7, 2023
Closed
ShwethaSNayak added a commit to ShwethaSNayak/pravega that referenced this pull request Feb 7, 2023
@ShwethaSNayak
Issue 2166: Improve logging for outstanding checkpoint (pravega#6974) (…
4b9289c 
…pravega#6994)

Cherry-pick PR pravega#6974 to master

Signed-off-by: Shwetha N <shwetha.n1@dell.com>
ShwethaSNayak added a commit that referenced this pull request Feb 7, 2023
@ShwethaSNayak
Issue 2166: Improve logging for outstanding checkpoint (#6974) (#6994) (
fc53411 
#6996)

Cherry-pick PR #6994 to r0.13

Signed-off-by: Shwetha N <shwetha.n1@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaulGracia RaulGracia RaulGracia approved these changes

@abhinb abhinb abhinb approved these changes

@tkaitchuck tkaitchuck Awaiting requested review from tkaitchuck

@shshashwat shshashwat Awaiting requested review from shshashwat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cherry-pick PR 6974 to master
4 participants
@ShwethaSNayak @RaulGracia @abhinb @tkaitchuck