Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename modaction.py to mod_action.py #1166

Merged
merged 4 commits into from
Dec 25, 2019
Merged

Rename modaction.py to mod_action.py #1166

merged 4 commits into from
Dec 25, 2019

Conversation

PythonCoderAS
Copy link
Contributor

Fixes # (provide issue number of applicable)

This feature provides a renamed modaction and a deprecation if you attempt to use the old one.

@bboe
Copy link
Member

bboe commented Dec 23, 2019

Thanks for the PR. I think you might have forgot to add the modaction.py with the deprecation warning. Also, there are likely places in the code which should import from mod_action instead of modaction now to avoid the package hitting the deprecationwarning, yes?

Oh also, we should mention the deprecation in the changelog providing the reason for the change, and the simple fix.

tests/conftest.py Outdated Show resolved Hide resolved
@bboe
Copy link
Member

bboe commented Dec 23, 2019

Cool, we just need a changelog entry, and then this is good to go. Thanks! And in this case, let's not worry about the decrease in coverage in coveralls. No need to test the deprecation warning.

@PythonCoderAS
Copy link
Contributor Author

Cool, we just need a changelog entry, and then this is good to go. Thanks! And in this case, let's not worry about the decrease in coverage in coveralls. No need to test the deprecation warning.

Lol too late

@bboe bboe merged commit abceb30 into praw-dev:master Dec 25, 2019
@bboe
Copy link
Member

bboe commented Dec 25, 2019

Thanks! You're awesome. 🎆

@PythonCoderAS PythonCoderAS deleted the patch-4 branch December 25, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants