-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1164) Add types to listing/mixins/redditor.py #1206
(#1164) Add types to listing/mixins/redditor.py #1206
Conversation
from urllib.parse import urljoin | ||
|
||
from ....util.cache import cachedproperty | ||
from ..generator import ListingGenerator | ||
from .base import BaseListingMixin | ||
from .gilded import GildedListingMixin | ||
|
||
Reddit = TypeVar("Reddit") | ||
_SubListing = TypeVar("_SubListing") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ordering or _.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it breaks the class sort order, I think it'd be preferable to define the SubListing
class before RedditorListingMixin
to avoid needing to use an underscore. Will you do that please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
It's a coverall error please re-run |
done. |
#1164
-> ./praw/models/listing/mixins/redditor.py