Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set conversation.obj_ids since it can be missing data #1877

Merged
merged 2 commits into from
May 21, 2022
Merged

Don't set conversation.obj_ids since it can be missing data #1877

merged 2 commits into from
May 21, 2022

Conversation

LilSpazJoekp
Copy link
Member

Fixes #1870

Feature Summary and Justification

This prevents conversation.obj_ids from being set when it doesn't have all the object ids. This also sets conversation.messages if num_messages is 1.

@LilSpazJoekp LilSpazJoekp added the Feature New feature or request label May 21, 2022
dequeued0
dequeued0 approved these changes May 21, 2022
View reviewed changes
Copy link

@dequeued0 dequeued0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks about right to me.

LilSpazJoekp
LilSpazJoekp commented May 21, 2022
View reviewed changes
praw/objector.py Outdated Show resolved Hide resolved
@LilSpazJoekp LilSpazJoekp merged commit ed85f6c into master May 21, 2022
@LilSpazJoekp LilSpazJoekp deleted the modmail_obj_ids branch May 21, 2022 20:36
@LilSpazJoekp LilSpazJoekp mentioned this pull request Nov 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dequeued0 dequeued0 dequeued0 approved these changes

Assignees
No one assigned
Labels
Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

modmail conversation messages list only includes the most recent message
2 participants
@LilSpazJoekp @dequeued0