Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for api/store_visits #951

Merged
merged 2 commits into from
Jun 21, 2018
Merged

Adding support for api/store_visits #951

merged 2 commits into from
Jun 21, 2018

Conversation

salehio
Copy link
Contributor

@salehio salehio commented Jun 19, 2018

Fixes #949

Adds support for the api/store_visits API.

References

https://www.reddit.com/dev/api/#POST_api_store_visits

Copy link
Member

@bboe bboe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome. Could you please add yourself to the AUTHORS.rst file, and add an entry in CHANGES.rst?

Thanks!

@@ -98,6 +98,16 @@ def mod(self):
self._mod = SubmissionModeration(self)
return self._mod

@property
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this into the correct location.

@salehio
Copy link
Contributor Author

salehio commented Jun 21, 2018

I added the changes to AUTHORS.rst and CHANGES.rst, and it should be ready for merging. coveralls is reporting decreased coverage though, so not sure if we can bypass that, or if I did something wrong.

@bboe bboe merged commit 8de3a59 into praw-dev:master Jun 21, 2018
@bboe
Copy link
Member

bboe commented Jun 21, 2018

Great work. Thanks! 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants