Raise error when zero length is provided to dash

prawnpdf · Oct 12, 2014 · e65c244 · e65c244 · Nowass · Dec 5, 2016
1 parent 371ef9d
commit e65c244
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/prawn/graphics/dash.rb b/lib/prawn/graphics/dash.rb
@@ -55,6 +55,11 @@ module Dash
       def dash(length=nil, options={})
         return current_dash_state if length.nil?
 
+        if length == 0 || length.kind_of?(Array) && length.any? { |e| e == 0 }
+          raise ArgumentError,
+            "Zero length dashes are invalid. Call #undash to disable dashes."
+        end
+
         self.current_dash_state = { :dash  => length,
                   :space => length.kind_of?(Array) ? nil : options[:space] || length,
                   :phase => options[:phase] || 0 }

diff --git a/spec/graphics_spec.rb b/spec/graphics_spec.rb
@@ -427,6 +427,14 @@
     @pdf.graphic_state.dash[:dash].should == 5
   end
 
+  it "should raise an error when dash is called w. a zero length or space" do
+    expect { @pdf.dash(0) }.to raise_error(ArgumentError)
+    expect { @pdf.dash([0]) }.to raise_error(ArgumentError)
+    expect { @pdf.dash([0,0]) }.to raise_error(ArgumentError)
+    expect { @pdf.dash([0,0,0,1]) }.to raise_error(ArgumentError)
+  end
+
+
   it "the current graphic state should keep track of previous unchanged settings" do
     @pdf.stroke_color '000000'
     @pdf.save_graphics_state