table column widths where not always correctly calculated - fixes bug reported under issue #628 #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bringing my fork up to date with original (prawndpdf:master)
bringing my fork up to date with original (prawndpdf:master)
|
Committed with minor typo fixes along with a change from In the future, please use a feature branch on the prawnpdf repository rather than your own fork, It makes collaboration between other committers easier. |
|
@sandal Thanks for the quick response. In the futrure I'll use the prawnpdf repo. Sorry for the inconvenience. |
|
It's only a minor detail, so no worries. Thanks a lot for your continued efforts on fixing up the table code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the edge case reported under issue #628 the column widths where not calculated correctly.
This pull requests solves the issue.