Always reset boxes to allow for redefinition of grid

[traels]

A small change with a test to prove that it works for issue #492

This MIGHT have a small impact on speed as the thing screwing things up was a instance variable caching the boxes that a grid creates.

[practicingruby]

Thanks for the patch. I will take a quick look at this before the 0.15.0 release and give some feedback when I do.

[practicingruby]

The way I understand this is that you want to clear @boxes when a grid is redefined, to avoid references to the old grid object.

If that's the case, why are we clearing the @boxes variable each time a grid's data is accessed, rather than each time it gets redefined?

[traels]

You are right, that would make more sense

[practicingruby]

Ok, so what this patch needs before it is merged is:

• move the @boxes assignment up into define_grid
• Make sure the tests still pass
• Add documentation indicating that calling define_grid multiple times will create a completely new grid object, affecting all grid calls that follow it. In other words, grids do not nest like bounding boxes.

[practicingruby]

@traels: If you want to work on updating the patch that may help get it merged sooner, otherwise I'll work on this when I get a chance.

[traels]

Should i just add manual update to this pull request?

kh
Simon Træls Ravn
Sent from my iPhone

On 14/02/2014, at 17.24, Gregory Brown notifications@github.com wrote:

@traels: If you want to work on updating the patch that may help get it merged sooner, otherwise I'll work on this when I get a chance.

—
Reply to this email directly or view it on GitHub.

[practicingruby]

All of the above you can do directly on this pull request, yeah. Just add some additional commits.

[practicingruby]

I see, you already moved the box clearing code. Yep, all we need is a manual and/or API doc update now!

[practicingruby]

I'll go ahead and try this patch out today and document it if it's working as I'd expect. I'll be cutting the 0.15.0 release this afternoon and I'd like to include this patch if possible.

[practicingruby]

Merged, thank you!

[practicingruby]

@traels: Because your pull request was accepted, you now have commit access to all of prawnpdf's repositories. Please see the link below for contribution guidelines, and thanks again!

https://github.com/prawnpdf/prawn/wiki/Contributor-welcome-notes