Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add git commit information on manual's cover only if in Git repo #691

Merged
merged 2 commits into from
Mar 10, 2014

Conversation

boutil
Copy link
Contributor

@boutil boutil commented Mar 9, 2014

Hi,

With this change I propose to add git commit information on the cover of Prawn's manual only if we are in a Git repository, i.e., if a .git directory is found in ../.., relatively to manual/manual/cover.rb.

Cheers,

Cédric

@practicingruby
Copy link
Member

@boutil I fixed some minor issues with this code, but I think it still does what you're looking for. Please confirm, and if so I'll merge.

@boutil
Copy link
Contributor Author

boutil commented Mar 10, 2014

@sandal I confirm its works great. Thanks for fixing my missing question mark.

practicingruby added a commit that referenced this pull request Mar 10, 2014
add git commit information on manual's cover only if in Git repo
@practicingruby practicingruby merged commit 6dbe601 into master Mar 10, 2014
@practicingruby practicingruby deleted the manual-cover-git branch July 27, 2014 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants