Support rack 2.x #320
Merged
Support rack 2.x #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josep M. Blanquer <blanquer@gmail.com>
Closed
careo
requested changes
Mar 2, 2017
lib/praxis/multipart/parser.rb
Outdated
| @@ -87,9 +88,13 @@ def setup_parse | |||
|
|
|||
| @buf = "" | |||
|
|
|||
| @params = Rack::Utils::KeySpaceConstrainedParams.new | |||
| @params = if rack_2x? | |||
There was a problem hiding this comment.
We could make this method definition itself conditional based on the logic below. It won't change at runtime, and shaving off the check couldn't hurt
Signed-off-by: Josep M. Blanquer <blanquer@gmail.com>
|
@thogg4 does this look good to you as well? since you were the one who initially looked at it? |
gampleman
reviewed
Mar 3, 2017
| @@ -20,7 +20,7 @@ Gem::Specification.new do |spec| | |||
| spec.bindir = 'bin' | |||
| spec.executables << 'praxis' | |||
|
|
|||
| spec.add_dependency 'rack', '~> 1' | |||
| spec.add_dependency 'rack', '>= 1' | |||
There was a problem hiding this comment.
Does is make sense to make this >= 1 < 3 so that this doesn't break with Rack 3?
There was a problem hiding this comment.
I don't foresee any rack 3 happening (just released version two now...and rack exists since 2007)...plus it is a low-level framework to major numbers are a big deal to release...so I don't think we should worry about it. IMO at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: @thogg4 regarding your PR #319 you had some of the basics in there but it was not properly done. Thank you very much for contributing though! it made it much easier to delve into it. See my comments in the PR.
Signed-off-by: Josep M. Blanquer blanquer@gmail.com