Ignore autogenerated CommitHash header and remove it from repo #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent accidentally including autogenerated code and making patches that are difficult to rebase. CommitHash.hpp is autogenerated by cmake and shouldn't be commited. Additionally someone with write access should do `git filter-branch` and remove CommitHash.hpp from the previous history or this problem may come back with merging older patches.
|
this is going to be an issue because cmkr will automatically recreate CMakeLists.txt with the CommitHash.hpp edit: Already did this in 38fa684 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent accidentally including autogenerated code and making patches that are difficult to rebase.
CommitHash.hpp is autogenerated by cmake and shouldn't be commited.
Additionally someone with write access should do
git filter-branchand remove CommitHash.hpp from the previous history or this problem may come back with merging older patches.