Ensuring compatibility with new changes. #50

Ashraf-Ali-aa · 2023-09-14T07:05:46Z

Update config to support mobile integrate

thehungrycoder · 2023-09-21T16:56:44Z

src/adhan/calculate.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-case-declarations */


why we need this?

ah, it was used from the mono repo code, I'll remove it for now but I might need to add it again.

thehungrycoder · 2023-09-21T16:57:43Z

src/adhan/calculation-methods.test.ts

@@ -16,10 +16,10 @@ describe('calculatePrayerTimes', () => {
      },
      timezone: 'Europe/London',
      calculationMethod: 'MoonsightingCommittee',
-      asrCalculation: 'hanafi',
+      asrCalculation: 'Hanafi',


i think these naming won't work as our api has different namings

it was based on https://github.com/prayersconnect/configs/blob/main/src/calc-methods/index.ts#L6

thehungrycoder · 2023-09-21T16:58:14Z

src/adhan/calculation-methods.ts

  Custom: {
+    calculationKey: 'Custom',


i think we called it just name in legacy implementation

the old code should not using this implementation but I think its method based off https://github.com/prayersconnect/configs/blob/main/src/calc-methods/index.ts#L5

thehungrycoder · 2023-09-21T16:59:11Z

src/adhan/calculation-methods.ts

 ) {
-  prayerTimeOptions.calculationParameters.madhab = asrCalcSetting;
+  const type =


thehungrycoder · 2023-09-28T13:45:57Z

src/calc-methods/index.ts

@@ -38,6 +44,22 @@ export const getCalcMethodsByCountry = (
  };
 };

+export const getCalculationMethodByCountry = (


don't we have same method above?
https://github.com/prayersconnect/configs/pull/50/files#diff-bd804961d106f9828ce84d7648ccef64bf9453731e7d3366b46b2c6fd93c3a7aR33

@thehungrycoder The reason why I created another implementation is that it will break older implementations of the code i.e. (web) if they used the updated config, the object structure is slightly different and uses different names for the calculation methods. With this approach, it will be safe to keep upgrading and not affect legacy implementation.

this concerns me as it will cause confusion of a module having two different methods of seemingly same purpose.

unless you can think of a cleaner approach, consider overloading

https://learntypescript.dev/05/l3-overloading

I do agree method overloading would be better, but since the method would be deprecated due to the calculation method names will no longer work in the future, I can add a @deprecated message

/** * @deprecated The method should not be used */

thehungrycoder · 2023-09-28T13:47:11Z

src/countries/index.ts

@@ -112,6 +118,10 @@ export function getConfigByISOName(name: string): ICountryConfig {
      ...defaultConfig.prayerSettings,
      ...countryConf?.prayerSettings,
    },
+    calculationSettings: {


is same info available under prayerSettings?

same as above, I was initially planning on using prayerSettings but I realised it would break legacy implementation so I have separated it out.

thehungrycoder · 2023-09-28T13:47:43Z

src/countries/prayers-configs.ts

@@ -23,6 +24,10 @@ export const defaultConfig = {
    asr_method: 'Standard',
    calculation_method: 'MWL',
  } as IPrayerSettings,
+  calculationSettings: {


if you look prayerSettings prop, these two values are available there.

…gles 15 and 18

thehungrycoder · 2023-10-31T13:22:43Z

package.json

@@ -44,6 +44,7 @@
  },
  "dependencies": {
    "adhan-extended": "^6.1.0",
-    "luxon": "^3.3.0"
+    "luxon": "^3.3.0",
+    "@photostructure/tz-lookup": "^8.0.0"


how good is this library? in mobile we use another library. please check and compare both and let's use the better one.

It is an up-to-date fork of tz-lookup (used in the mobile app) since it is no longer maintained by darkskyapp
https://github.com/photostructure/tz-lookup

Ashraf-Ali-aa force-pushed the update-config branch from 76139cc to 63fddc8 Compare September 14, 2023 08:21

Ashraf-Ali-aa mentioned this pull request Sep 17, 2023

Add Algeria calculation method #46

Closed

Ashraf-Ali-aa force-pushed the update-config branch 3 times, most recently from bfe5960 to 5337387 Compare September 21, 2023 06:08

Ashraf-Ali-aa marked this pull request as ready for review September 21, 2023 06:12

Ashraf-Ali-aa requested a review from thehungrycoder September 21, 2023 06:12

Ashraf-Ali-aa force-pushed the update-config branch from 5337387 to ab39661 Compare September 21, 2023 17:37

thehungrycoder reviewed Sep 21, 2023

View reviewed changes

Ashraf-Ali-aa force-pushed the update-config branch from ab39661 to ebe2a7a Compare September 21, 2023 18:07

thehungrycoder reviewed Sep 28, 2023

View reviewed changes

Ashraf-Ali-aa force-pushed the update-config branch from ebe2a7a to ecb314b Compare October 1, 2023 13:17

ensuring compatibility with new changes.

9f993c1

Ashraf-Ali-aa force-pushed the update-config branch 11 times, most recently from 7626e5d to 7efc443 Compare October 24, 2023 07:01

Ashraf-Ali-aa force-pushed the update-config branch from 7efc443 to 8e2d3be Compare October 28, 2023 14:00

feat(calculation methods): Add calculation methods for France with an…

b344e25

…gles 15 and 18

Ashraf-Ali-aa force-pushed the update-config branch from 8e2d3be to b344e25 Compare October 30, 2023 06:47

thehungrycoder reviewed Oct 31, 2023

View reviewed changes

timezone

94deb94

Ashraf-Ali-aa force-pushed the update-config branch from 171ba1e to 94deb94 Compare October 31, 2023 19:48

Ashraf-Ali-aa merged commit adf46fa into main Nov 2, 2023
10 checks passed

Ashraf-Ali-aa deleted the update-config branch November 2, 2023 07:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensuring compatibility with new changes. #50

Ensuring compatibility with new changes. #50

Ashraf-Ali-aa commented Sep 14, 2023

thehungrycoder Sep 21, 2023

Ashraf-Ali-aa Sep 21, 2023

thehungrycoder Sep 21, 2023

Ashraf-Ali-aa Sep 21, 2023 •

edited

Loading

thehungrycoder Sep 21, 2023

Ashraf-Ali-aa Sep 21, 2023

thehungrycoder Sep 21, 2023

thehungrycoder Sep 28, 2023

Ashraf-Ali-aa Oct 1, 2023

thehungrycoder Oct 1, 2023

Ashraf-Ali-aa Oct 1, 2023 •

edited

Loading

thehungrycoder Sep 28, 2023

Ashraf-Ali-aa Oct 1, 2023

thehungrycoder Sep 28, 2023

thehungrycoder Oct 31, 2023

Ashraf-Ali-aa Oct 31, 2023 •

edited

Loading

Ensuring compatibility with new changes. #50

Ensuring compatibility with new changes. #50

Conversation

Ashraf-Ali-aa commented Sep 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ashraf-Ali-aa Sep 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ashraf-Ali-aa Oct 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ashraf-Ali-aa Oct 31, 2023 • edited Loading

Choose a reason for hiding this comment

Ashraf-Ali-aa Sep 21, 2023 •

edited

Loading

Ashraf-Ali-aa Oct 1, 2023 •

edited

Loading

Ashraf-Ali-aa Oct 31, 2023 •

edited

Loading