Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: interpreters #129

Merged
merged 1 commit into from
Sep 4, 2020
Merged

add: interpreters #129

merged 1 commit into from
Sep 4, 2020

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Sep 4, 2020 •
edited

the lest known might be: https://linux.die.net/man/1/expect

This is needed downstream to better catching supported vs non-supported shells for shellcheck : see cachix/git-hooks.nix#63 (comment)

I didn't bother adding corresponding file extensions, since:

  • I don't know them for sure
  • The vast majority of cases will probably be covered by this
  • If there is need & knowledge, I suggest to add them individually

@blaggacao blaggacao mentioned this pull request Sep 4, 2020
Merged
asottile
asottile approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 260bb77 into pre-commit:master Sep 4, 2020
@blaggacao blaggacao mentioned this pull request Sep 5, 2020
Closed
Emilv2 added a commit to Emilv2/git-hooks that referenced this pull request Sep 5, 2020
@Emilv2
Restrict shellcheck and shfmt to supported shells
01ace4f 
shmft and shellcheck don't work on zsh and some others shells.

when pre-commit/identify#129 is in a release
ash, dats and ksh will be identified and work.
@Emilv2 Emilv2 mentioned this pull request Sep 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blaggacao @asottile