Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

towards #35 #63

Merged
merged 3 commits into from Oct 6, 2020
Merged

towards #35 #63

merged 3 commits into from Oct 6, 2020

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Sep 4, 2020

#35


Do not merge before pre-commit/identify#129 landed in a release which is then acctually used here.

@roberth
Copy link
Contributor

roberth commented Sep 4, 2020

@blaggacao
Copy link
Contributor Author

blaggacao commented Sep 4, 2020

    goodShells = [
        "sh",
        "ash",
        "dash",
        "bash",
        "bats",
        "ksh"
        ]

    badShells = [
        "awk",
        "csh",
        "expect",
        "perl",
        "python",
        "ruby",
        "tcsh",
        "zsh"
        ]

@blaggacao
Copy link
Contributor Author

blaggacao commented Sep 4, 2020

The problem will be *.sh extension since I believe identity gives precedence to extension over shebang.


I was wrong:

If executable, the shebang is read and the interpreter interpreted


So we need to get those good shells upstreamed as extension (except .sh) and interpreter.

pre-commit/identify#129

@blaggacao
Copy link
Contributor Author

Do not merge before pre-commit/identify#129 landed in a release which is then acctually used here.

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
@domenkozar
Copy link
Member

identify now just needs a bump in nixpkgs

@domenkozar
Copy link
Member

Going to fix as part of #65 that will include the bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants